Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technique validation schemas #194

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add technique validation schemas #194

merged 1 commit into from
Jun 12, 2024

Conversation

simonfernandes
Copy link
Contributor

Description

This is part of creating techniques for the STFC Xpress access route in the software. We are currently creating a new concept of techniques that have instruments attached to them (will be done via another core PR that is not yet created) and this is the validation for it.

Motivation and Context

How Has This Been Tested

We've tested this by temporarily moving the schemas inside the user-office-core and importing from there. Once this is merged we can update the imports.

Fixes

Part of UserOfficeProject/issue-tracker#1095

Changes

Adds technique validation schemas

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@simonfernandes simonfernandes added the review: please A request for an ad-hoc review. label Jun 12, 2024
@simonfernandes simonfernandes requested review from a team, TCMeldrum and yoganandaness and removed request for a team June 12, 2024 08:21
@simonfernandes simonfernandes merged commit 45e9948 into master Jun 12, 2024
3 checks passed
@simonfernandes simonfernandes deleted the 1095 branch June 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: please A request for an ad-hoc review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants