feat: delta cache manager #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sighphyre
approved these changes
Feb 21, 2025
|
|
||
| #[derive(Debug, Clone)] | ||
| pub enum DeltaCacheUpdate { | ||
| Full(String), // environment with a newly inserted cache |
There was a problem hiding this comment.
Might be asking for too much here, but it's not possible for the Full to just be a special case of Update? Be cool to only have two cases here but I really dunno if that's possible with your future plans
There was a problem hiding this comment.
I am considering dropping it altogether after I confirm it's not needed in the next PR
server/src/delta_cache_manager.rs
Outdated
| self.caches.get(env).map(|entry| entry.value().clone()) | ||
| } | ||
|
|
||
| pub fn insert_cache(&self, env: String, cache: DeltaCache) { |
There was a problem hiding this comment.
Can I suggest taking a &str here? It usually makes for a nicer API when working with literals and since you're cloning it anyway in the body, there's no real hit to memory
chriswk
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
We used store delta cache per environment:
let delta_cache: DashMap<String, DeltaCache> = DashMap::default();After this change we will be able to use:
let delta_cache_manager = DeltaCacheManager::new();The manager will hide the dash map but also handle updates broadcasting for streaming purposes.
This API is symmetrical to how we handle FeatureCache. As a result switching streaming code from full updates to deltas will be almost a drop-in replacement.
Important files
Discussion points
Calling something a manager is controversial. I'm open to changing this name it but after this code is merged and used in another PR that I've been working on.