feat: streaming delta api #751
Open
+286
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
…leash/unleash-edge into feat/streaming-delta-epi-edge-support
…aming-delta-epi-edge-support
kwasniew
commented
Feb 21, 2025
|
|
||
| if tokio::time::timeout(std::time::Duration::from_secs(2), async { | ||
| loop { | ||
| if let Some(Ok(event)) = stream.next().await { | ||
| let next = stream.next().await; | ||
| if let Some(Ok(event)) = next { |
kwasniew
commented
Feb 21, 2025
| if tokio::time::timeout(std::time::Duration::from_secs(2), async { | ||
| loop { | ||
| if let Some(Ok(event)) = stream.next().await { | ||
| let next = stream.next().await; | ||
| if let Some(Ok(event)) = next { |
kwasniew
commented
Feb 21, 2025
server/tests/streaming_test.rs
Outdated
| assert_eq!(initial_features.query, update.query); | ||
| assert_eq!(initial_features.version, update.version); | ||
| assert_ne!(initial_features.features, update.features); | ||
| // TODO: uncomment when we can filter by id |
There was a problem hiding this comment.
can uncomment this one now since we do filtering
kwasniew
commented
Feb 21, 2025
server/src/http/broadcaster.rs
Outdated
| &self, | ||
| query: StreamingQuery, | ||
| ) -> Result<DeltaEvent, EdgeError> { | ||
| // do we need filter_set for hydration event? |
There was a problem hiding this comment.
we do need to filter hydration event features. will be done in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This PR adds streaming support for delta events.
Important terminology:
On the wire it looks like this:
or
When SDK connects to edge for the first time it gets unleash-connected event with the hydration event type.
On each subsequent update in Unleash only unleash-updated events are propagated with the changes that the SDK hasn't seen yet. For each connection Edge remembers the last event id that has been broadcasted before.
Important files
Discussion points