-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flow rate to simulation view #9410
Conversation
d9c7a93
to
986a54f
Compare
Oh, you don't need to make the actual appimage. I just test Cura when running it from source. In 99% of the cases running it from source is the same as the appimage / binary. In the few cases that it isn't, we have a automatic build system that spits out nightlies and which gets used & tested by our QA engineers. |
Hi @khani3s I was wondering if you're still stuck and if that is the case how I could help you. I kinda like what you're doing here, sot it would be great if we could merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're almost there. If you implement the following fixes in the code, you should have something working. See the image below.
I would suggest that you name it Flow rate
instead of Flow
and it might be a good idea to merge master into your own branch again since there were many changes in between your PR and now.
Don't worry about setting up the complete build environment, if it runs from source it will most likely run in our builds as well and we have the automatic tests to catch errors as well.
Btw it looks like something is a bit off with the max flow rate calculation. A flow of 26 mm3/s is very high
I finally managed to run the code. https://github.com/Ultimaker/Cura/wiki/Running-Cura-from-Source-on-Ubuntu
For documentation purposes: The version of PyQT listed on the wiki was wrong.
|
What version of PyQt and Qt have you installed? |
I think you stumbled across a "typo" or mistake. According to the qtquick documentation, module "QtQuick.Controls" version 2.11 does not exist yet, and the file should actually be using module "QtQuick.Controls" version 2.4. It is interesting though that you are the first to stumble into this as something that stops Cura from loading. |
I have created #9799 to fix the version issue. |
I was using the Qt recommended here: https://github.com/Ultimaker/Cura/wiki/Running-Cura-from-Source-on-Ubuntu PyQt5==5.10 The requirements.txt version solved the problem: PyQt5==5.15.2 |
I notice that too. And after debugging I think that is related to the "Fill Gaps lines". |
Whoops. I've updated the documentation. |
@nallath could you send me that project? |
The issue only occurs if you only show the helpers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think that visualisation bug is because of this recently merged pull request: #9498
Co-authored-by: Ghostkeeper <[email protected]>
The fix suggested by @Ghostkeeper fixes it, so i've merged this! Github is however not quite understanding that :S ( But fear not; it is in the next release!) |
WIP
Add Flow rate to simulation view
Flow Rate (AKA volumetric flow rate, volume flow rate, rate of fluid flow, volume velocity or volumetric speed) is used defined on 3dp as
line width * thickness * feedrate
. The unit is mm³/sIs useful to check if your printing inside your hot end/extruder limits.
This implementation is based on #9289 and does not take into account (I think) material_flow.
TODO
I need some guide of how to test this on my machine (Ubuntu 18.04.5 LTS).
I tried the "docker way" and after reading all the doc multiple times (cura-build-enviroment, cura-build, cura, wiki) I can't figure out how to build it and generate the AppImage.
I follow the CI build steps and got the same build output but I couldn't find out a way to get the binary for testing on my local machine.
I already invested +8 hours on the "build"