-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add line width to simulation view #9289
Add line width to simulation view #9289
Conversation
Implements CURA-7741.
Tests failing seems to be a problem from previous commits on the Arachne_rebased branch. Or rather, from the Master branch which only fail due to being outdated on Arachne. |
Why not merge it in the master branch? And I mean ofcourse just this change nor the whole rebase 😉 |
For posterity: we cherry-picked this to Master. It will be in the 4.9 release then. |
I was looking for a way to display flow rate on the simulation view. Could I just go ahead and implement it and open a PR? |
I've had a quick glance over our product backlog and I couldn't find it in there. So feel free to create a PR for it. Chances are pretty high that it gets accepted. Adding an extra view here isn't going to burden us and there is some value to it. |
Correct me if I am wrong, but getting the flow rate into simulation view is a whole lot harder than getting the line width in there, because the line width was already part of the layer data that is passed from CuraEngine to Cura but the flow rate is not. |
The flow rate can be calculated in the shader from the line width, layer height and speed, which are all available in the layer data. The speed is inaccurate since it doesn't know about accelerations and jerks, but it'll then be just as inaccurate as the "speed" colour scheme. I had originally considered if I should add this as well since it's quite useful and not so hard, but due to the time frame in which this was implemented I didn't get that far. |
It's nice to show this when working with variable line width.
Implements CURA-7741.