Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line width to simulation view #9289

Merged

Conversation

Ghostkeeper
Copy link
Collaborator

It's nice to show this when working with variable line width.

image

Implements CURA-7741.

@Ghostkeeper
Copy link
Collaborator Author

Tests failing seems to be a problem from previous commits on the Arachne_rebased branch. Or rather, from the Master branch which only fail due to being outdated on Arachne.

@jellespijker
Copy link
Member

jellespijker commented Feb 18, 2021

Why not merge it in the master branch?
Granted it will not show that much difference on the current engine generated GCode but we also have different line widths there.

And I mean ofcourse just this change nor the whole rebase 😉

@jellespijker jellespijker merged commit ab97973 into libArachne_rebased Feb 19, 2021
@jellespijker jellespijker deleted the CURA-7741_line_width_simulation_view branch February 19, 2021 07:19
@Ghostkeeper
Copy link
Collaborator Author

Ghostkeeper commented Feb 24, 2021

For posterity: we cherry-picked this to Master. It will be in the 4.9 release then.

@khani3s
Copy link
Contributor

khani3s commented Mar 15, 2021

I was looking for a way to display flow rate on the simulation view.
And looking at this PR, the implementation seems to be quite straightforward.

Could I just go ahead and implement it and open a PR?
( I can't find out if its already planned or not, and I also don't find out much information of how a feature is selected)

@nallath
Copy link
Member

nallath commented Mar 16, 2021

I've had a quick glance over our product backlog and I couldn't find it in there.

So feel free to create a PR for it. Chances are pretty high that it gets accepted. Adding an extra view here isn't going to burden us and there is some value to it.

@fieldOfView
Copy link
Collaborator

Correct me if I am wrong, but getting the flow rate into simulation view is a whole lot harder than getting the line width in there, because the line width was already part of the layer data that is passed from CuraEngine to Cura but the flow rate is not.

@khani3s khani3s mentioned this pull request Mar 17, 2021
4 tasks
@Ghostkeeper
Copy link
Collaborator Author

Correct me if I am wrong, but getting the flow rate into simulation view is a whole lot harder than getting the line width in there, because the line width was already part of the layer data that is passed from CuraEngine to Cura but the flow rate is not.

The flow rate can be calculated in the shader from the line width, layer height and speed, which are all available in the layer data. The speed is inaccurate since it doesn't know about accelerations and jerks, but it'll then be just as inaccurate as the "speed" colour scheme.

I had originally considered if I should add this as well since it's quite useful and not so hard, but due to the time frame in which this was implemented I didn't get that far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants