-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some MetaMask bugs #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pai <[email protected]>
…k provider Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
@chrismaree could you take a first pass on this? |
chrismaree
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrice32
reviewed
Feb 21, 2020
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
Signed-off-by: Nick Pai <[email protected]>
mrice32
reviewed
Feb 21, 2020
Signed-off-by: Nick Pai <[email protected]>
mrice32
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deriveKeyPairFromSignatureMetamask
(fromCrypto.js
) when commiting and revealing votes, now commit, reveal work wellweb3.contract.getPastEvents
) doesn't work all the time, notably it works sometimes for readingVoteRevealed
events but has never worked forPriceResolved
. These events are needed to retrieve rewards and show price resolution results, respectively. Therefore, I have added checks to detect if the user is using a metamask provider and to subsequently block certain functionality if so.node-metamask
and fixed a bug where it does not properly convert scientific notation into numbers, notably when callingweb3.eth.getBalance()
on an account with a lot of ETH (e.g. 10,000 ETH), it retrieves this result as "1e+22" instead of "10000....000" which causes downstream bignumber errors. I made a PR into the mainnode-metamask
repo about this.This is part of #901
Resolves #953