-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI utility shows wrong etherscan links when generating tx #953
Labels
enhancement
New feature or request
Milestone
Comments
Agreed, we have a common lib that should help with that: protocol/common/PublicNetworks.js Lines 1 to 26 in b6844d3
We use it in the sponsor dapp to generate etherscan links: protocol/sponsor-dapp-v2/src/lib/custom-hooks.js Lines 53 to 66 in b6844d3
|
Merged
Added a fix for this in #951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the CLI utility always generates a link to etherscan.io, even if running on test net or local.
![image](https://user-images.githubusercontent.com/12886084/75053282-fb8b5580-549e-11ea-82fc-7622b9170859.png)
This should dynamically change based on the network.
The text was updated successfully, but these errors were encountered: