Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add property name to the response's type/format change message #477

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

tcdsv
Copy link
Collaborator

@tcdsv tcdsv commented Jan 28, 2024

issue: #474

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (a2470e3) 83.75% compared to head (2b410b9) 83.85%.
Report is 2 commits behind head on main.

Files Patch % Lines
delta/endpoints.go 79.31% 4 Missing and 2 partials ⚠️
delta/parameters.go 90.62% 2 Missing and 1 partial ⚠️
delta/schema.go 57.14% 2 Missing and 1 partial ⚠️
internal/delta.go 91.89% 2 Missing and 1 partial ⚠️
internal/changelog_flags.go 0.00% 2 Missing ⚠️
internal/diff_flags.go 0.00% 2 Missing ⚠️
delta/delta.go 95.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   83.75%   83.85%   +0.10%     
==========================================
  Files         217      225       +8     
  Lines       12593    12799     +206     
==========================================
+ Hits        10547    10733     +186     
- Misses       1668     1683      +15     
- Partials      378      383       +5     
Flag Coverage Δ
unittests 83.85% <91.03%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcdsv tcdsv requested a review from reuvenharrison January 28, 2024 09:23
@tcdsv tcdsv linked an issue Jan 28, 2024 that may be closed by this pull request
@reuvenharrison reuvenharrison merged commit 8b6e8c9 into Tufin:main Jan 28, 2024
7 checks passed
effoeffi added a commit to oasdiff/oasdiff that referenced this pull request Feb 1, 2024
* add flag to control colorful output (Tufin#433)

* Bump github.com/oasdiff/go-common from 0.2.27 to 0.2.28 (Tufin#444)

* color-flag completion (Tufin#447)

* Bump cloud.google.com/go from 0.110.10 to 0.111.0 (Tufin#448)

* prevent---color-with-non-text-formats (Tufin#449)

* upgrade-to-kin-openapi-v0.122.0 (Tufin#450)

* diff-add-exclude-elements-options (Tufin#454)

* remove-hardcoded-quotes (Tufin#455)

* Correct int messages (Tufin#456)

* fix test (Tufin#457)

* add qr code (Tufin#458)

* typo

* github-annotations-with-api (Tufin#452)

* add source file to github (Tufin#459)

* Change sample sunset date to self-explain that it's YYYY-MM-DD format (Tufin#460)

* github-avoid-http-files (Tufin#462)

* Update ALLOF.md

* flatten command - fix wrong Title and Description values (Tufin#464)

* flatten command - prune oneOf field on circular references (Tufin#466)

* lower-min-go-ver (Tufin#471)

* update Breaking Changes to Enum Values

* Bump cloud.google.com/go from 0.111.0 to 0.112.0 (Tufin#472)

* delta (Tufin#473)

* add property name to the response's type/format change message (Tufin#477)

* documentation (Tufin#478)

* Update DELTA.md (Tufin#480)

---------

Co-authored-by: Reuven Harrison <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: effoeffi <[email protected]>
Co-authored-by: Maciej Lewiński <[email protected]>
Co-authored-by: Omer E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include property name in error message
3 participants