Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-to-kin-openapi-v0.122.0 #450

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Nov 30, 2023

Update to latest version of kin-openapi which is breaking.
@tcdsv please check the changes in flatten and also consider this in the context of the planned abstraction through interfaces (using functions instead of accessing members directly)
@effoeffi sharing this to help you fix oasdiff-service

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (20282b1) 83.72% compared to head (cbe4c80) 83.66%.

Files Patch % Lines
flatten/merge_allof_spec.go 27.77% 11 Missing and 2 partials ⚠️
diff/diff.go 62.50% 1 Missing and 2 partials ⚠️
checker/check-api-removed.go 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   83.72%   83.66%   -0.06%     
==========================================
  Files         216      216              
  Lines       12477    12502      +25     
==========================================
+ Hits        10446    10460      +14     
- Misses       1658     1668      +10     
- Partials      373      374       +1     
Flag Coverage Δ
unittests 83.66% <81.52%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcdsv
Copy link
Collaborator

tcdsv commented Dec 4, 2023

I reviewed the changes in flatten, it seems to be ok.

@reuvenharrison reuvenharrison merged commit ac02167 into main Dec 4, 2023
@reuvenharrison reuvenharrison deleted the upgrade-to-kin-openapi-v0.122.0 branch December 4, 2023 15:24
effoeffi added a commit to oasdiff/oasdiff that referenced this pull request Feb 1, 2024
* add flag to control colorful output (Tufin#433)

* Bump github.com/oasdiff/go-common from 0.2.27 to 0.2.28 (Tufin#444)

* color-flag completion (Tufin#447)

* Bump cloud.google.com/go from 0.110.10 to 0.111.0 (Tufin#448)

* prevent---color-with-non-text-formats (Tufin#449)

* upgrade-to-kin-openapi-v0.122.0 (Tufin#450)

* diff-add-exclude-elements-options (Tufin#454)

* remove-hardcoded-quotes (Tufin#455)

* Correct int messages (Tufin#456)

* fix test (Tufin#457)

* add qr code (Tufin#458)

* typo

* github-annotations-with-api (Tufin#452)

* add source file to github (Tufin#459)

* Change sample sunset date to self-explain that it's YYYY-MM-DD format (Tufin#460)

* github-avoid-http-files (Tufin#462)

* Update ALLOF.md

* flatten command - fix wrong Title and Description values (Tufin#464)

* flatten command - prune oneOf field on circular references (Tufin#466)

* lower-min-go-ver (Tufin#471)

* update Breaking Changes to Enum Values

* Bump cloud.google.com/go from 0.111.0 to 0.112.0 (Tufin#472)

* delta (Tufin#473)

* add property name to the response's type/format change message (Tufin#477)

* documentation (Tufin#478)

* Update DELTA.md (Tufin#480)

---------

Co-authored-by: Reuven Harrison <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: effoeffi <[email protected]>
Co-authored-by: Maciej Lewiński <[email protected]>
Co-authored-by: Omer E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants