fix: enable maintenance mode only if there is an upgrade to perform #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ migrateToDatabaseVersion = function migrateToDatabaseVersion(version, logger, mo | |||
| * ## Update | |||
| * Does a backup, then updates the database and fixtures | |||
| */ | |||
| update = function update(options) { | |||
| execute = function update(options) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I feel like, after this is merged, it's probably worth doing some more migration testing, which I've not done for a little while. I don't have time this evening (gotta drive) but can do first thing in the morning. |
kirrg001
force-pushed
the
fix/check-if-migration-update-needs-to-happen
branch
2 times, most recently
from
fe1a234 to
13b8569
Compare
refs TryGhost#7125 - create isDatabaseOutOfDate fn for initial migration update checks - only set maintenance.enabled to true if migration needs to happen
kirrg001
force-pushed
the
fix/check-if-migration-update-needs-to-happen
branch
from
13b8569 to
0414864
Compare
5 tasks
chris-brown
pushed a commit
to chris-brown/Ghost
that referenced
this pull request
Aug 14, 2016
…ryGhost#7129) refs TryGhost#7125 - create isDatabaseOutOfDate fn for initial migration update checks - only set maintenance.enabled to true if migration needs to happen
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this pull request
Nov 20, 2016
…ryGhost#7129) refs TryGhost#7125 - create isDatabaseOutOfDate fn for initial migration update checks - only set maintenance.enabled to true if migration needs to happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7125
Right now
maintenance.enabledis always set to true on bootstrap. It could happen in theory, that the first request ends in a 503 response. Let's optimise that!isDatabaseOutOfDatefn for initial migration update checksmaintenance.enabledto true if migration needs to happen