Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance mode issues / tweaks #7125

Closed
5 tasks done
ErisDS opened this issue Jul 23, 2016 · 1 comment
Closed
5 tasks done

Maintenance mode issues / tweaks #7125

ErisDS opened this issue Jul 23, 2016 · 1 comment
Milestone
0.9.0

Comments

@ErisDS
Copy link
Member

ErisDS commented Jul 23, 2016 •
edited by kirrg001
Loading

Just writing this down quickly whilst it is in my head:

  • Refreshing / rendering the admin in maintenance mode results in a blank page and this error:
  • Maintenance mode is always overridden by it being set to false after migration on boot, so cannot be set in config.js (fixed in Allow maintenance mode to be set in config.js #7124).
  • Maintenance mode is always enabled and then disabled on boot regardless of whether there is any work to be done, which could result in the first request showing a Maintenance Error.
  • There is no error message for Maintenance mode, meaning the error page just shows "503 Maintenance" which isn't clear to non-technical people
  • 503 errors should not have stack traces, as the stack is not relevant to the problem. This + a nice error message will make the 503 error page much clearer and better for users.
@ErisDS ErisDS mentioned this issue Jul 23, 2016
Merged
@kevinansfield kevinansfield added this to the 0.9.0 milestone Jul 25, 2016
@kirrg001 kirrg001 mentioned this issue Jul 25, 2016
Merged
ErisDS added a commit to ErisDS/Ghost that referenced this issue Jul 25, 2016
@ErisDS
Allow maintenance mode to be set in config.js
54388e1 
refs TryGhost#6976, TryGhost#7019, TryGhost#7125

- Ensure maintenance mode flag is set back to what is in config.js rather than defaulted to false on boot
- Remove stack trace from 503 errors
- Add error message to 503 error
- Ensure error page is rendered for Ghost-Admin on reload with 503
kirrg001 pushed a commit that referenced this issue Jul 25, 2016
@ErisDS @kirrg001
Allow maintenance mode to be set in config.js (#7124)
d08926c 
refs #6976, #7019, #7125

- Ensure maintenance mode flag is set back to what is in config.js rather than defaulted to false on boot
- Remove stack trace from 503 errors
- Add error message to 503 error
- Ensure error page is rendered for Ghost-Admin on reload with 503
kirrg001 added a commit to kirrg001/Ghost that referenced this issue Jul 26, 2016
@kirrg001
fix: enable maintenance mode only if there is an upgrade to perform
0414864 
refs TryGhost#7125
- create isDatabaseOutOfDate fn for initial migration update checks
- only set maintenance.enabled to true if migration needs to happen
ErisDS pushed a commit that referenced this issue Jul 26, 2016
@kirrg001 @ErisDS
fix: enable maintenance mode only if there is an upgrade to perform (#…
417b9b6 
…7129)

refs #7125
- create isDatabaseOutOfDate fn for initial migration update checks
- only set maintenance.enabled to true if migration needs to happen
@ErisDS
Copy link
Member Author

ErisDS commented Jul 26, 2016

This is all done by #7124 and #7129

@ErisDS ErisDS closed this as completed Jul 26, 2016
chris-brown pushed a commit to chris-brown/Ghost that referenced this issue Aug 14, 2016
@ErisDS @chris-brown
Allow maintenance mode to be set in config.js (TryGhost#7124)
14987c4 
refs TryGhost#6976, TryGhost#7019, TryGhost#7125

- Ensure maintenance mode flag is set back to what is in config.js rather than defaulted to false on boot
- Remove stack trace from 503 errors
- Add error message to 503 error
- Ensure error page is rendered for Ghost-Admin on reload with 503
chris-brown pushed a commit to chris-brown/Ghost that referenced this issue Aug 14, 2016
@kirrg001 @chris-brown
fix: enable maintenance mode only if there is an upgrade to perform (T…
7153c3d 
…ryGhost#7129)

refs TryGhost#7125
- create isDatabaseOutOfDate fn for initial migration update checks
- only set maintenance.enabled to true if migration needs to happen
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@ErisDS @geekhuyang
Allow maintenance mode to be set in config.js (TryGhost#7124)
d6bdb9b 
refs TryGhost#6976, TryGhost#7019, TryGhost#7125

- Ensure maintenance mode flag is set back to what is in config.js rather than defaulted to false on boot
- Remove stack trace from 503 errors
- Add error message to 503 error
- Ensure error page is rendered for Ghost-Admin on reload with 503
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@kirrg001 @geekhuyang
fix: enable maintenance mode only if there is an upgrade to perform (T…
241229c 
…ryGhost#7129)

refs TryGhost#7125
- create isDatabaseOutOfDate fn for initial migration update checks
- only set maintenance.enabled to true if migration needs to happen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@kevinansfield @ErisDS