Fix test dependencies for subpackages and subpackage tests/examples enables (#63, #268, #299, #510) #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabartlett1972
previously approved these changes
Aug 11, 2022
There was a problem hiding this comment.
I am going to allow this to merge without a review because this is desperately needed to fix trilinos/Trilinos#10842 which will allow a bunch of PRs to pass Trilinos PR testing and be merged.
This was referenced Aug 11, 2022
…riBITSPub#511) I noticed that some important TriBITS logic that was not documented in the build reference guide. I noticed this while working on TriBITSPub#510 and TriBITSPub#511 (but, again, this is just documenting existing behavior).
…TriBITSPub#200) This eliminates a lot of dupication, reduces the number of lines of code, and removes a bunch of clutter from the functions tribits_add_test_directories() and tribits_add_example_directories(). Win, win, win. I noticed this while working on TriBITSPub#510.
…riBITSPub#510) These configurations fail to build without the fixes that come in the next commit (see TriBITSPub#510). Also, this pins down that you should only enable tests for subpackages that need tested based on explicit and forward enables (see TriBITSPub#268). I also added some configure checks for how I want the output to look mostly as part of TriBITSPub#268.
…nabless (TriBITSPub#63, TriBITSPub#268, TriBITSPub#299, TriBITSPub#510) This fixes a defect added as part of transitioning to modern CMake targets (TriBITSPub#63, TriBITSPub#299). As part of this, it also changes the behavior of TriBITS to only enable tests/examples for subpackages that are enabled on the forward sweep and not those that are enabled as part of sweeping backward to enabled upstream dependencies needed by enabled packages (see TriBITSPub#268). This is the correct thing to do and will also result in fewer tests being being built and run as part of testing downstream packages using: -D<Project>_ENABLE_<Pkg>=ON -D<Project>_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON -D<Project>_ENABLE_TESTS=ON These changes causes failing tests in the previous commit to pass. I also updated some documentation and removed some commented-out debugging code.
bartlettroscoe
force-pushed
the
510-fix-spkg-test-dependencies
branch
from
26dc679 to
b00ab33
Compare
rabartlett1972
approved these changes
Aug 11, 2022
|
Hello @KyleFromKitware, can you please do a post-merge review of this PR? Thanks! |
6 tasks
| if (${PARENT_PACKAGE_NAME}_ENABLE_TESTS) | ||
| if ("${${fullSpkgName}_ENABLE_TESTS}" STREQUAL "") | ||
| message("-- " "Setting" | ||
| " ${fullSpkgName}_ENABLE_TESTS=${${PARENT_PACKAGE_NAME}_ENABLE_TESTS}" |
There was a problem hiding this comment.
Not sure how picky you are about whitespace, but you've got some stray tabs here.
There was a problem hiding this comment.
Initial tabs are a no-no. Not sure how that got inserted (my emacs editor should be setup to indent with spaces only). I will diffidently fix that.
Thanks!
There was a problem hiding this comment.
This is addressed in new PR #515. I found a bunch of other places where tabs somehow got inserted. I wish there was a simple linter that could catch this. (Actually, to look for initial tabs in *.cmake files, then that is easy. I can do that with a simple bash scripts.)
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Aug 13, 2022
Somehow tabs got inserted instead of spaces when indenting in these files. I replaces tabs with 8 spaces and things seem to look about correct.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Aug 13, 2022
Somehow tabs got inserted instead of spaces when indenting in these files. I replaces tabs with 8 spaces and things seem to look about correct.
bartlettroscoe
added a commit
that referenced
this pull request
Aug 13, 2022
Replace leading tabs with 8 spaces (#512)
bartlettroscoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses specifically the defect in #510 which resulted from work done as part of #63 and #299. This also mostly addresses the scope of #268.
Once this is updated to Trilinos, it will fix trilinos/Trilinos#10842.
See the specific git commit log messages for more detail.