Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INVALID: TriBITS not enabling downstream package with test-only dependency on upstream package with <Project>_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON #511

Closed
bartlettroscoe opened this issue Aug 11, 2022 · 1 comment
Closed

INVALID: TriBITS not enabling downstream package with test-only dependency on upstream package with <Project>_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON #511

bartlettroscoe opened this issue Aug 11, 2022 · 1 comment
Labels
component: core resolution: invalid type: bug

Comments

@bartlettroscoe
Copy link
Member

While working on #510, I discovered that TriBITS is not enabling downstream packages that only have test dependencies on an upstream package. For example, if you configure TribitsExampleProject with:

-DTribitsExProj_ENABLE_MixedLang=ON \
-DTribitsExProj_ENABLE_TESTS=ON \
-DTribitsExProj_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON  \

you don't get the subpackage WithSubpackagesB enabled and have its test built even though that package has an optional test dependency on MixedLang.
@bartlettroscoe
Copy link
Member Author

Turns out TriBITS was doing the right thing. I just had not enabled ST packages when setting up my test.

Closing as INVALID.

@bartlettroscoe bartlettroscoe changed the title TriBITS not enabling downstream package with test-only dependency on upstream package with <Project>_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON INVALID: TriBITS not enabling downstream package with test-only dependency on upstream package with <Project>_ENABLE_ALL_FORWARD_DEP_PACKAGES=ON Aug 11, 2022
bartlettroscoe added a commit to bartlettroscoe/TriBITS that referenced this issue Aug 11, 2022
@bartlettroscoe
Add some build reference doc for existing behavior (TriBITSPub#510, T…
c91bba4 
…riBITSPub#511)

I noticed that some important TriBITS logic that was not documented in the
build reference guide.  I noticed this while working on TriBITSPub#510 and TriBITSPub#511 (but,
again, this is just documenting existing behavior).
bartlettroscoe added a commit to bartlettroscoe/TriBITS that referenced this issue Aug 11, 2022
@bartlettroscoe
Add some build reference doc for existing behavior (TriBITSPub#510, T…
bfd9b6f 
…riBITSPub#511)

I noticed that some important TriBITS logic that was not documented in the
build reference guide.  I noticed this while working on TriBITSPub#510 and TriBITSPub#511 (but,
again, this is just documenting existing behavior).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core resolution: invalid type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlettroscoe