Addition of offZ cuts in topcoffea

[anpicci]

This comes with the PR in topeft for refactoring the category definitions.
TopEFT/topeft#431

[bryates]

Looks good to me.

[kmohrman]

Other than my small comment on describing the new function, this looks good to me. If you could address the comment, I would be happy for it to be merged after that.

[kmohrman]

@anpicci @ywan2 did you want this PR to be merged? Or is it waiting on something on the topeft side?

Once my very minor comment above is addressed, I would be happy to merge it into topcoffea.

[anpicci]

@kmohrman we are running some final validations, we will keep you posted here

[kmohrman]

@kmohrman we are running some final validations, we will keep you posted here

Hi, just wondering if there are any updates on these validations?

[anpicci]

As soon as @jlawrenc concludes the validation for the tau channel, we merge this PR, which will introduce both the revisited off-Z channels from @ywan2 and John's tau analysis in the master branch

[bryates]

As soon as @jlawrenc concludes the validation for the tau channel, we merge this PR, which will introduce both the revisited off-Z channels from @ywan2 and John's tau analysis in the master branch

Since this PR is pretty basic, should we merge it now @kmohrman?

[kmohrman]

As soon as @jlawrenc concludes the validation for the tau channel, we merge this PR, which will introduce both the revisited off-Z channels from @ywan2 and John's tau analysis in the master branch

Since this PR is pretty basic, should we merge it now @kmohrman?

From the above, it sounded like @anpicci intended to wait to merge till those items on the topeft side had been addressed. @anpicci did you want to move forward now or is that still in progress?

[kmohrman]

Just checking in. Wondering if the proponents of this PR could comment on the status and plans.

[ywan2]

@kmohrman I think this PR can be merged anytime, since it doesn't affect running any of the existing codes, and its corresponding topeft PR 431 should be ready too. @jlawrenc, @bryates, @anpicci, should we just merge this?

[bryates]

@kmohrman I think this PR can be merged anytime, since it doesn't affect running any of the existing codes, and its corresponding topeft PR 431 should be ready too. @jlawrenc, @bryates, @anpicci, should we just merge this?

I'm fine with merging now if @kmohrman is.

[kmohrman]

It's ok with me, as long as you can confirm that this stuff is good to go (as I think Andrea had suggested waiting on that).

[bryates]

It's ok with me, as long as you can confirm that this stuff is good to go (as I think Andrea had suggested waiting on that).

@anpicci any comments on this, or should we merge now?

[kmohrman]

It's ok with me, as long as you can confirm that this stuff is good to go (as I think Andrea had suggested waiting on that).

@anpicci any comments on this, or should we merge now?

Happy New Year!
Just in case this thread got buried, just wanted to bring it up so that we can merge once everyone is happy with it.

[bryates]

It's ok with me, as long as you can confirm that this stuff is good to go (as I think Andrea had suggested waiting on that).

@anpicci any comments on this, or should we merge now?

Happy New Year! Just in case this thread got buried, just wanted to bring it up so that we can merge once everyone is happy with it.

I'm fine with merging now since this only adds new features an doesn't alter any existing code. But @anpicci and @ywan2 let me know if you'd prefer we wait.

[anpicci]

@bryates it should be fine, but I would let @ywan2 give the green light, when she's available to provide her feedback