-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3l-offZ event categories division update #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm happy merging this into this repo, but @kmohrman does this line up with your refactoring plans? It's sort of analysis specific, but at the same time, it's general enough that anyone can use it.
|
||
# Returns a mask for all events with any os lepton pair within low region of off-Z | ||
# Mask will be True if any combination of 2 leptons from within the given collection satisfies the requirement | ||
def get_off_Z_mask_low(lep_collection,pt_window,flavor="os"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to generalize this a bit, we could remove _low
from the name, and change pt_window
to a string that takes "low"
or "high"
# Mask will be True if any combination of 2 leptons from within the given collection satisfies the requirement | ||
def get_off_Z_mask_low(lep_collection,pt_window,flavor="os"): | ||
ll_pairs = ak.combinations(lep_collection, 2, fields=["l0","l1"]) | ||
zpeak_mask = ((91.2-(ll_pairs.l0+ll_pairs.l1).mass)>pt_window) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we generalize this, then the pt_window
comparison would change.
I agree that this is right on the border of what might make sense to go in topcofea vs topeft. I guess there's nothing actually strictly analysis specific about it (even though right now it's just being used by one analysis) so probably is fine here. I would pass mass of the Z as an argument though (you could leave 91.2 as the default, as we do in the other pt of the Z mask function), since others might want to use e.g. 91.1876. |
I'm wondering if someone could please comment on the status of this PR? Is it still intended to be merged at some point, or has it been superseded by a different PR in topcoffea and/or topeft? |
Hi @kmohrman, This branch's function is implemented in a new branch. So it's not going to be merged. We can delete it. Thanks for checking! |
Ok, thanks for the update! Just to confirm, are you ok the PR being closed and its associated branch (3l-offZ) being removed from the topcoffea repository? Or did you still need the branch as a reference? |
This PR is crucial for the update of analysis including the division of 3l event categories.
The changes are made in
event_selection.py
to add an extra masking for low mass region of 3l-offZ channels (to use in the analysis processor in topeft).