docker: bump base image #1791
Merged
docker: bump base image #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
commented
Apr 24, 2024
Comment on lines
+21
to
+22
| - python >=3.10 | ||
| - numpy >=1.23 |
There was a problem hiding this comment.
or potentially
Suggested change
| - python >=3.10 | |
| - numpy >=1.23 | |
| - python >=3.10,<3.13 | |
| - numpy >=1.23,<1.27 |
There was a problem hiding this comment.
It's not every combination within there though hopefully conda can figure that out in practise. Can a user specify the python version on the command line or would that need a python = x.x?
gfardell
reviewed
Apr 24, 2024
paskino
approved these changes
Apr 24, 2024
gfardell
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.shpermissions again (can people stop modding them please)?Related issues/links
Checklist
I have updated the relevant documentationI have implemented unit tests that cover any new or modified functionalityCHANGELOG.md has been updated with any functionality changeContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.