Add thread lock to boto3 resource #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholsondarius
changed the title
|
Leaving this PR in draft until #74 is merged or closed as it mentions not needing to thread lock. |
|
I was still getting errors because my GitHub Actions self-hosted runner wasn't updating to the latest version of the adapter. After force reinstalling the adapter, things have been running fine. |
Avinash-1394
pushed a commit
to Avinash-1394/dbt-athena
that referenced
this pull request
Jan 12, 2023
* append '/' to not delete tables that share same suffix in s3 location * fix test and compose loggin message from objects actually used for deletion (since logging message is used in test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66 was merged recently but I have still been getting the errors it set out to resolve.
This documentation on the boto3 resource says that the resource is also not thread safe.
This PR adds a thread lock to the instantiation of the boto3 resource.