[BUGFIX] Resolve boto3 client threading issue #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 Thank you! |
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoint_resolver & credential_provider
Currently dbt-athena allows for multiple threads for computation. This is causing errors when generating multiple
boto3.clientcalls simultaneously as it is not thread safe. In order to rectify this issue, we apply a thread lock in the adapter to temporarily lock the threads to allow for safe creation of each boto3 client. This addresses theendpoint_resolverandcredential_providerissues many of us have been seeing frequently.pytest adapter
I also updated the pytest-dbt-adapter version as 0.5.1 failed all tests. Bumping the version to 0.6.0 appears to work appropriately with dbt-core 1.0.3.