Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use memcmp to compare IP_Ports. #2605

Merged
merged 1 commit into from
Jan 29, 2024

fix: Don't use `memcmp` to compare `IP_Port`s.

39aadf8
Select commit
Loading
Failed to load commit list.
Merged

fix: Don't use memcmp to compare IP_Ports. #2605

fix: Don't use `memcmp` to compare `IP_Port`s.
39aadf8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2024 in 1s

73.60% (-0.13%) compared to d94246a

View this Pull Request on Codecov

73.60% (-0.13%) compared to d94246a

Details

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d94246a) 73.72% compared to head (39aadf8) 73.60%.

Files Patch % Lines
toxcore/network.c 61.76% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
- Coverage   73.72%   73.60%   -0.13%     
==========================================
  Files         148      148              
  Lines       30369    30407      +38     
==========================================
- Hits        22390    22380      -10     
- Misses       7979     8027      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov