Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use memcmp to compare IP_Ports. #2605

Merged
merged 1 commit into from
Jan 29, 2024

fix: Don't use `memcmp` to compare `IP_Port`s.

39aadf8
Select commit
Loading
Failed to load commit list.
Merged

fix: Don't use memcmp to compare IP_Ports. #2605

fix: Don't use `memcmp` to compare `IP_Port`s.
39aadf8
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Jan 29, 2024 in 16s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: Don't use memcmp to compare IP_Ports.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: Don't use memcmp to compare IP_Ports.

memcmp compares padding bytes as well, which may be arbitrary or
uninitialised.
Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : memcmp compares padding bytes as well, which may be arbitrary or uninitialised.

This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}