Revert "Do not run CI in PR twice" #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0cd2714.
dudoslav
reviewed
Oct 25, 2024
| push: | ||
| branches: [dev] | ||
| pull_request: | ||
| branches: [dev] |
There was a problem hiding this comment.
I think that we should just remove this condition for pull_request but leave other untoched
There was a problem hiding this comment.
After some consideration and a small chat with Agis I have decided that sometimes it is also necessary to run CI on every branch, even without PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2082 might have fixed the initial issue, but it causes PRs that we want to merge into non-dev branches to not run CI at all. For example: #2099.
If there is no other solution, we should revert.