Merge Metadata and GroupMetadata into one Python class
#2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After further consideration, I believe this change will break backward compatibility. More testing is needed, specifically writing metadata with older tiledb-py versions and reading it with this version, and vice versa. |
kounelisagis
force-pushed
the
agis/merge-metadata-and-groupmetadata-classes
branch
from
63a2d49 to
d085808
Compare
kounelisagis
force-pushed
the
pybind11-full
branch
from
4a4f4b1 to
9493586
Compare
kounelisagis
force-pushed
the
agis/merge-metadata-and-groupmetadata-classes
branch
from
d085808 to
27b9ec9
Compare
kounelisagis
force-pushed
the
agis/merge-metadata-and-groupmetadata-classes
branch
from
27b9ec9 to
c9098ab
Compare
|
In #2099, backward compatibility has been fixed. After rebasing the pybind11-full branch onto the |
nguyenv
approved these changes
Oct 30, 2024
kounelisagis
deleted the
agis/merge-metadata-and-groupmetadata-classes
branch
ihnorton
reviewed
Oct 31, 2024
| namespace py = pybind11; | ||
| using namespace pybind11::literals; | ||
|
|
||
| template <typename T> class MetadataAdapter { |
kounelisagis
added a commit
that referenced
this pull request
Dec 9, 2024
* Delete Cython * Add new pybind11 Adapter class * Move Python class + fixes * Fix tests
kounelisagis
added a commit
that referenced
this pull request
Dec 20, 2024
* Delete Cython * Add new pybind11 Adapter class * Move Python class + fixes * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2085, this PR removes the Cython
Metadataclass and renames Python'sGroupMetadataclass toMetadata. The newMetadataclass is now shared between theArrayandGroupclasses, as both classes now have aself._metaproperty that is an instance of this class.Additionally, the common pybind11 code has been moved to a separate
metadata.ccfile, within an adapter templated class that works for both theArrayandGroupclasses.CI: https://github.com/TileDB-Inc/TileDB-Py/actions/runs/11503873688
[sc-54605]