Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed catboost and added new tqdm #22

Merged
merged 2 commits into from
May 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/arfs/feature_selection/allrelevant.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
import scipy as sp

from typing import Tuple
from tqdm import tqdm
from tqdm.auto import tqdm
from sklearn.utils import check_random_state, check_X_y
from sklearn.base import BaseEstimator, is_regressor, is_classifier, clone

Expand Down Expand Up @@ -494,7 +494,7 @@ def _get_tree_num(self, n_feat):
n_estimators : int
the number of trees
"""
depth = self.estimator.get_params()["max_depth"]
depth = self.estimator.get_params()["max_depth"] if not self.is_cat else self.estimator.get_param("max_depth")
if depth is None:
depth = 10
# how many times a feature should be considered on average
Expand Down
2 changes: 1 addition & 1 deletion src/arfs/feature_selection/mrmr.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pandas as pd
from sklearn.base import BaseEstimator
from sklearn.utils.validation import check_is_fitted
from tqdm import tqdm
from tqdm.auto import tqdm
from sklearn.feature_selection._base import SelectorMixin
from ..association import (
f_stat_classification_parallel,
Expand Down
2 changes: 1 addition & 1 deletion src/arfs/preprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

# Settings and libraries
from __future__ import print_function
from tqdm import tqdm
from tqdm.auto import tqdm

# pandas
import pandas as pd
Expand Down