Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I see you've been working on the project, you are doing great job!
Catboost does not have keys of parameters, which weren't passed in initialization, so your
_get_tree_num
will raise KeyError. My PR fixes it.gives KeyError
Also when I was using your module in jupyter notebook, it has been using not fancy looking tqdm. It is easy to fix by using
from tqdm.auto import tqdm
which will import nice tqdm if it can, otherwise will use usual version.