Skip to content

Fix: Worker Has Wrong Death Animation When Carrying Boxes #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Jul 16, 2023

Situation in 1.04:

Situation in current patch main branch

Repro:

1.mp4

Situation with this fix

  • The correct death animation is played in all cases:
1.mp4

@commy2 commy2 added Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker GLA Affects GLA faction labels Jul 16, 2023
@commy2
Copy link
Collaborator Author

commy2 commented Jul 16, 2023

Imho, the ideal fix would be if the engine reset the CARRYING flag on death, but w/e.

@xezon
Copy link
Contributor

xezon commented Jul 16, 2023

1528_worker_death_animation.yaml file needs to be updated.

@xezon
Copy link
Contributor

xezon commented Jul 16, 2023

Instead of renaming the updated yaml file, I suggest to create a txt file for 2120_worker_death_animation.txt and write in it the existing yaml file. This way we can find files for both pull numbers. I have used this approach for several other changes already. This just makes it a bit easier to find things.

The old date also does not need to be updated.

@commy2
Copy link
Collaborator Author

commy2 commented Jul 16, 2023

Even though this PR completely undoes all changes in #1528?

@xezon
Copy link
Contributor

xezon commented Jul 16, 2023

In that case what you can also do is edit the opening text of #1528 and note that it has been reverted or superseeded, so anyone looking at it knows it has no relevance anymore.

@commy2 commy2 merged commit fea824d into main Jul 16, 2023
@commy2 commy2 deleted the fix-carrying-worker-death-animation branch July 16, 2023 21:02
@ItsWazzaP ItsWazzaP added the GameMismatchWith104 Affects game state towards original 1.04 label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right GameMismatchWith104 Affects game state towards original 1.04 GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker With Supply Plays Wrong Animation When Blown Up
3 participants