WIP: initial work to convert to FAKE 5

[baronfel]

Proposed Changes

Begin the API migration to fake 5. This does not do the 'runner' migrations, just the api changes.

'IsRelease' isn't something that's determine-able anymore (at least as far as I can tell. Will open an issue on FAKE to discuss) so that means some additional work had to go into making the test run build with sourcelink.

Right now the net461 build is the one that's failing due to reference errors. Build log is:

Starting task 'DotNet:build': MyCoolLib.sln
/usr/local/share/dotnet/dotnet  build /p:PackageVersion=0.1.0 /p:SourceLinkCreate=true --no-restore MyCoolLib.sln --configuration Release
Microsoft (R) Build Engine version 15.6.82.30579 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Data". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Drawing". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Core". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Runtime.Serialization". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml.Linq". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Numerics". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.IO.Compression.FileSystem". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
FSC : error FS0229: Error opening binary file '/mscorlib.dll': Could not find file '/mscorlib.dll'. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
  MyCoolLib -> /private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/bin/Release/netstandard2.0/MyCoolLib.dll
  MyCoolLib -> /private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/bin/Release/netstandard1.6/MyCoolLib.dll
  MyCoolLib.Tests -> /private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/tests/MyCoolLib.Tests/bin/Release/netcoreapp1.1/MyCoolLib.Tests.dll
  MyCoolLib.Tests -> /private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/tests/MyCoolLib.Tests/bin/Release/netcoreapp2.0/MyCoolLib.Tests.dll
Build FAILED.
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Data". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Drawing". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Core". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Runtime.Serialization". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Xml.Linq". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.Numerics". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
/usr/local/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(2052,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "System.IO.Compression.FileSystem". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
FSC : error FS0229: Error opening binary file '/mscorlib.dll': Could not find file '/mscorlib.dll'. [/private/var/folders/80/y0q8bqgx29bd8g3h0tlt00k00000gn/T/f2d6e3e5acfb42bfa57848704ef1ef6c/MyCoolLib/src/MyCoolLib/MyCoolLib.fsproj]
    9 Warning(s)
    1 Error(s)

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• Build and tests pass locally
• I have added tests that prove my fix is effective or that my feature works (if appropriate)
• I have added necessary documentation (if appropriate)

Further comments

I'm mostly opening this to serve as a discussion point. The changes currently don't pass and I'm hoping someone else sees where I went wrong.

[baronfel]

the test fails for me now with an error finding mscorlib, so that's great.

But I also included a fix for the chmod issue, which is just invoking /bin/sh -c "chmod +x *.sh". This needs a workaround because you have to confirm the action, but I added a write to stdin so that tests can continue.

Any idea what the deal is the with the mscorlib thing? It's only on the net461 build, and is quite irritating. I tried bumping to 2.1.200 but that doesn't actually change anything for mono....

[TheAngryByrd]

I'm bumping mono to 5.12 and the dotnet core sdk to 2.1.301 in #93, so might fix some issues

[TheAngryByrd]

Closing in favor of #104. Thanks for the initial work though! :)