-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
77 fake5 #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great!
The only caveat I might say is to add a #r
paket group reference to the build.fsx, that gets you two things:
- you don't have to do an explicit paket restore in your scripts (you're not but just to be explicit)
- fake will reference your existing paket group and ensure you're restored/up-to-date/generate the intellisense.fsx.
That group ref looks like #r "paket: groupref netcorebuild //"
, more info here: https://fake.build/fake-migrate-to-fake-5.html#Add-FAKE-dependencies
Ah, should this advice also make it's way back into the fake-template? |
So, I was doing this by using the comment block technique. They seem equivalent? https://fake.build/fake-fake5-modules.html#Reference-paket-group |
Proposed Changes
Closes #77
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...