Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

77 fake5 #104

Merged
merged 8 commits into from
Aug 29, 2018
Merged

77 fake5 #104

merged 8 commits into from
Aug 29, 2018

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

Closes #77

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great!

The only caveat I might say is to add a #r paket group reference to the build.fsx, that gets you two things:

  • you don't have to do an explicit paket restore in your scripts (you're not but just to be explicit)
  • fake will reference your existing paket group and ensure you're restored/up-to-date/generate the intellisense.fsx.

That group ref looks like #r "paket: groupref netcorebuild //", more info here: https://fake.build/fake-migrate-to-fake-5.html#Add-FAKE-dependencies

@TheAngryByrd
Copy link
Owner Author

Ah, should this advice also make it's way back into the fake-template?

@TheAngryByrd
Copy link
Owner Author

So, I was doing this by using the comment block technique. They seem equivalent? https://fake.build/fake-fake5-modules.html#Reference-paket-group

@baronfel baronfel merged commit 6a70678 into master Aug 29, 2018
@baronfel baronfel deleted the 77-fake5 branch August 29, 2018 20:41
TheAngryByrd pushed a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
TheAngryByrd pushed a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
TheAngryByrd pushed a commit that referenced this pull request Aug 30, 2018
* FEATURE: FAKE 5 (#104)
* FEATURE: Add Code Coverage threshold (#103)
* MAINTENANCE: Added fsc and netfx props files (#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAKE 5
2 participants