-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make output type switchable #65
Conversation
So the giraffe-template build has some permutation tests we could probably imitate with FAKE |
@@ -1,4 +1,5 @@ | |||
{ | |||
"$schema": "http://json.schemastore.org/template", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo I didn't know about this!
One of the other issues is that Libs are Exe are |
Also from slack discussion, we probably need a https://docs.microsoft.com/en-us/dotnet/core/deploying/deploy-with-cli Probably projects filtered by src and |
Although uninstall with -u does not work, re-installing (as shown below) does update the template to the latest version on nuget. Not sure how how you test a branch though. dotnet new -i "MiniScaffold::*" |
You should be able to uninstall with As for testing a branch, you'll have to build it yourself and install the nupkg that resides in the |
Also looks like we'll need to add a Program.fs or corresponding some entrypoint |
I'm thinking there's enough different here that we'll probably want to create another folder under |
Going to close in favor of #105 |
Proposed Changes
F# slack has expressed a desire to make an executable from this template.
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I would love to test this but I can't figure out how to uninstall a previous version of the template.
Also the build script seems to be building the inner Content folder, which with this change is no longer buildable, because the output type
MyOutputType
isn't valid. I didn't see a good way to keep that a buildable value but not accidentally find-and-replace a billion instances ofLib
in the project.