-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console app #105
Merged
Merged
Console app #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
console-app
branch
2 times, most recently
from
September 6, 2018 20:11
3a1a3f2
to
9d6c96d
Compare
TheAngryByrd
force-pushed
the
console-app
branch
3 times, most recently
from
September 9, 2018 17:46
45d93d6
to
e0352c3
Compare
TheAngryByrd
force-pushed
the
console-app
branch
from
September 9, 2018 17:54
e0352c3
to
1d9fdca
Compare
TheAngryByrd
force-pushed
the
console-app
branch
from
September 9, 2018 18:14
38ab567
to
0cc7569
Compare
CI keeps failing due to some mono/paket issue. |
baronfel
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I added a couple of enhancements on the other PR.
Two enhancements to the console app MR
TheAngryByrd
pushed a commit
that referenced
this pull request
Sep 11, 2018
* FEATURE: Console App Scaffold Support (#105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allows scaffolding a console app version of MiniScaffold
Types of changes
What types of changes does your code introduce to MiniScaffold?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...