perf: update message stream without waiting for websocket event #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkothari22
deleted the
1353-update-chat-stream-when-new-message-is-sent-without-web-socket-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On sending a message, we update the chat stream with the new message as soon as we get a response from the API call. This isn't optimistic )we still wait for the API call), but it's much better UX wise since we don't need to wait for the web socket event to be broadcast and received.
If websocket is not connected, Raven will try reconnect automatically (max 3 times), and if that fails, we show a toast for 5 seconds asking the user to refresh.