-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/login api #19
Merged
Merged
Fix/login api #19
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d919277
fix: remove unnecessary variable declaration
seohyun-106 54b6d97
fix: replace data with resData
seohyun-106 d2e8e61
fix: apply constant to statusCode
seohyun-106 c622dcb
fix: combine Controller parameter to req.body
seohyun-106 0c07a75
fix: apply prettier
seohyun-106 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,22 +97,22 @@ const postSignupService = async ({ email, nickname, password }) => { | |
* @access public | ||
*/ | ||
|
||
const postLoginService = async (email: string, password: string) => { | ||
const postLoginService = async ({ email, password }) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. req.body를 받을때 타입선언 하겠습니다 |
||
// 요청 바디 부족 | ||
if (!email || !password) { | ||
return -1; | ||
return constant.NULL_VALUE; | ||
} | ||
|
||
// 존재하지 않는 이메일 | ||
const user = await User.findOne({ where: { email: email } }); | ||
if (!user) { | ||
return -2; | ||
return -100; | ||
} | ||
|
||
// 비밀번호 일치 X | ||
const isMatch = await bcrypt.compare(password, user.password); | ||
if (!isMatch) { | ||
return -3; | ||
return -101; | ||
} | ||
|
||
// 성공 시 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
req.body를 받을때 타입선언 하겠습니다