Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/login api #19

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Fix/login api #19

merged 5 commits into from
Jan 12, 2022

Conversation

seohyun-106
Copy link
Contributor

@seohyun-106 seohyun-106 commented Jan 12, 2022 •
edited
Loading

✅ PR check list

  • commit message가 적절한지 확인해주세요.
  • 마지막으로 Coding Convention을 준수했는지 확인해주세요.
  • 적절한 branch로 요청했는지 확인해주세요.
  • Assignees, Label을 붙여주세요.
  • 가능한 이슈를 Link 해주세요.
  • PR이 승인된 경우 해당 브랜치는 삭제 부탁드립니다.

🌈 PR 요약

  • login api PR 코드리뷰 커멘트들을 반영했습니다

📌 변경 사항

  • 불필요한 변수 선언 삭제
  • statusCode에 동근짱의 constant library 적용
  • Controller 파라미터 req.body로 통일
  • 프리티어 적용 확인

⚠️ 특이사항

  • find 함수 사용할 때 isDeleted 체크하는 코드 적용하지 못했습니다. DB 수정 후 반영하도록 하겠슴다

Linked Issue

close #17

@seohyun-106 seohyun-106 added 🌈 refactor 코드 리팩토링 2️⃣ priority: middle 우선순위 중간 labels Jan 12, 2022
@seohyun-106 seohyun-106 self-assigned this Jan 12, 2022
geeneve
geeneve approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@geeneve geeneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실행해볼 생각에 벌써 신나요

holmir97
holmir97 approved these changes Jan 12, 2022
View reviewed changes
src/controller/auth.ts
@@ -100,38 +100,36 @@ const postSignupController = async (req: Request, res: Response) => {

const postLoginController = async (req: Request, res: Response) => {
try {
const { email, password } = req.body;
const data = await authService.postLoginService(email, password);
const resData = await authService.postLoginService(req.body);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req.body를 받을때 타입선언 하겠습니다

src/service/auth.ts
@@ -97,22 +97,22 @@ const postSignupService = async ({ email, nickname, password }) => {
* @access public
*/

const postLoginService = async (email: string, password: string) => {
const postLoginService = async ({ email, password }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req.body를 받을때 타입선언 하겠습니다

@holmir97 holmir97 merged commit c6f6b49 into develop Jan 12, 2022
@geeneve geeneve deleted the fix/login-api branch January 13, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geeneve geeneve geeneve approved these changes

@holmir97 holmir97 holmir97 approved these changes

Assignees

@seohyun-106 seohyun-106

Labels
2️⃣ priority: middle 우선순위 중간 🌈 refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] fix login
3 participants
@seohyun-106 @holmir97 @geeneve