fix: move token generation to agent #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhossler
added a commit
that referenced
this pull request
Apr 1, 2024
* fix: move token generation to agent (#1) * fix: add uri to token storage key to prevent clashes (#2) * Catch up with upstream (#3) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]> * chore: run mix format on our changes (#4) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]> * chore: undo random formatting changes that aren't necessary --------- Co-authored-by: Drew Ballance <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]>
jmhossler
pushed a commit
that referenced
this pull request
Apr 1, 2024
jmhossler
added a commit
that referenced
this pull request
May 7, 2024
* fix: move token generation to agent (#1) * chore: undo random formatting changes that aren't necessary * feat: implement a pushy push notification adapter * fix: implement connect_socket method * feat: add pushy notification constructor * fix: do @SPEC new instead of @new smh * fix: add return type to new spec * fix: update connect parameters and add docs link in mix * debug: add error log so I can tell why connection to pushy isn't working * fix: require logger in pushy dispatcher * fix: do a regular inspect of the error instead when connecting to pushy * fix: adjust socket connection settings to attempt to resolve handshake failure * refactor: don't use socket when connecting to pushy, just make http requests since ssl cert was throwing * fix: correctly call pushy_headers and remove unnecessary match * fix: use notification encode_requests to encode the payload * fix: move over encoding logic so I can encode properly * fix: remove unmatched curly brace and use correct encode request impl * fix: don't pass in more params than necessary to error.parse * fix: correct the pushy path for pushing notifications * fix: remove error parse on good data, just return response from pushy * fix: pass notification around appropriately in do_push for pushy * feat: add result parser to handle both error and success cases * fix: add additional notification fields to hold response info * fix: address some invalid variable refs and remove unused param from error * fix: pass the resulting json instead of some fictitious result parser to the result parser * fix: handle case where failed devices might not be included * fix: remove old reference to failed devices * fix: parse errors into notification structs instead of just atom * feat: add helper methods for filling in additional parameters for pushy notifications * fix: add missing empty curly bracket and format files * docs(pushy): add documentation for notification and pushy module * refactor: change order of new to take destination as first parameter and data as an optional second parameter * test: implement basic pushy test implementation * feat: ensure pushy config is validated * Fix compilation errors and warnings * Make the default uri a string, not a charlist * fix: put variable on the right side of pattern match in parameter list * chore: point kadabra dep at branch with added telemetry metrics * chore: publish telemetry events for ping RTT for FCM and APNS adapters * fix: remove fcm adapter ping addition and handling * chore: update ping RTT calculation to use time sent in ping request to ensure accurate measurements * Expose foreign address in response messages (#5) --------- Co-authored-by: Drew Ballance <[email protected]> Co-authored-by: Nathan Alderson <[email protected]>
jmhossler
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of codedge-llc#227