Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow httpoison 2.0 #236

Merged
merged 5 commits into from
Feb 18, 2023
Merged

fix: allow httpoison 2.0 #236

merged 5 commits into from
Feb 18, 2023

Conversation

hpopp
Copy link
Member

@hpopp hpopp commented Feb 18, 2023

Addresses #234

@hpopp hpopp merged commit a40679a into master Feb 18, 2023
@hpopp hpopp deleted the fix/httpoison-2.0 branch February 18, 2023 20:44
@hpopp hpopp mentioned this pull request Feb 18, 2023
jmhossler added a commit to Tango-Tango/pigeon that referenced this pull request Mar 17, 2023
* fix: allow httpoison 2.0 (codedge-llc#236)

* fix: allow httpoison 2.0

* ci: fix workflows

* ci: revert to ubuntu-latest

* ci: use setup-beam@v1

* chore: update CHANGELOG

* docs: update README links

* fix: move token generation into Pigeon.APNS.Token (codedge-llc#227)

This means the token is only generated once and used across all workers

* chore: update CHANGELOG

---------

Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Andrew Timberlake <[email protected]>
jmhossler added a commit to Tango-Tango/pigeon that referenced this pull request Mar 17, 2023
* fix: allow httpoison 2.0 (codedge-llc#236)

* fix: allow httpoison 2.0

* ci: fix workflows

* ci: revert to ubuntu-latest

* ci: use setup-beam@v1

* chore: update CHANGELOG

* docs: update README links

* fix: move token generation into Pigeon.APNS.Token (codedge-llc#227)

This means the token is only generated once and used across all workers

* chore: update CHANGELOG

---------

Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Andrew Timberlake <[email protected]>
@prkhrkat
Copy link

prkhrkat commented May 4, 2023

I'm. still getting this -

(base) prakhar@prakhar-katiyar-MacBook-Pro medqcx % mix deps.update --all
Resolving Hex dependencies...
#Incompatibility<#Term, cause: {:conflict, #Incompatibility<#Term= 1.1.5>, cause: {:conflict, #Incompatibility<#Term= 1.1.5>, #Term<not httpoison ~> 0.7 or ~> 1.0>, cause: :dependency>, #Incompatibility<#Term, #Term<not httpoison ~> 2.0>, cause: :dependency>}>, #Incompatibility<#Term, #Term<not pigeon ~> 2.0.0-rc.1>, cause: :dependency>}>
Resolution completed in 0.13s
Because pigeon >= 1.1.5 depends on httpoison ~> 0.7 or ~> 1.0 and your app depends on httpoison ~> 2.0, pigeon >= 1.1.5 is forbidden.
So, because your app depends on pigeon ~> 2.0.0-rc.1, version solving failed.
** (Mix) Hex dependency resolution failed

hpopp added a commit that referenced this pull request Nov 24, 2023
* fix: move token generation to agent (#1)

* fix: add uri to token storage key to prevent clashes (#2)

* Catch up with upstream (#3)

* fix: allow httpoison 2.0 (#236)

* fix: allow httpoison 2.0

* ci: fix workflows

* ci: revert to ubuntu-latest

* ci: use setup-beam@v1

* chore: update CHANGELOG

* docs: update README links

* fix: move token generation into Pigeon.APNS.Token (#227)

This means the token is only generated once and used across all workers

* chore: update CHANGELOG

---------

Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Andrew Timberlake <[email protected]>

* chore: run mix format on our changes (#4)

* fix: allow httpoison 2.0 (#236)

* fix: allow httpoison 2.0

* ci: fix workflows

* ci: revert to ubuntu-latest

* ci: use setup-beam@v1

* chore: update CHANGELOG

* docs: update README links

* fix: move token generation into Pigeon.APNS.Token (#227)

This means the token is only generated once and used across all workers

* chore: update CHANGELOG

---------

Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Andrew Timberlake <[email protected]>

* chore: undo random formatting changes that aren't necessary

---------

Co-authored-by: Drew Ballance <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Henry Popp <[email protected]>
Co-authored-by: Andrew Timberlake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants