Refactor: address input #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UrbanWill
commented
Sep 21, 2024
| @@ -5,9 +5,9 @@ export const useOnClickOutside = (element: HTMLElement | undefined | null, cb: ( | |||
| function handleClickOutside(event: MouseEvent) { | |||
| if (element && !element.contains(event.target as Node)) cb() | |||
| } | |||
| document.addEventListener('click', handleClickOutside) | |||
| document.addEventListener('mousedown', handleClickOutside) | |||
There was a problem hiding this comment.
TIL mousedown works best because it waits for events to fully propagate.
Co-authored-by: Chris Ling <[email protected]>
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on: #82
Issue: #79
AddressInputto be a standalone component responsible for infinite fetching and searching contacts related data, this was the final requirement to get rid of the address watcher pattern.AddressInputAddressBookTableto handle unpaid Organizations without relying onAddressBookWatcherAddressBookWatcher, which queried up to 1000 Contacts with categories & subcategories.address-bookrelated functions🖼️ Screenshots:
AddressInput
Screen.Recording.2024-09-21.at.15.31.37.mov
AddressBook free organization plan view
Screen.Recording.2024-09-21.at.15.36.55.mov