Refactor: useKownAddresses #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
chrisling-dev
approved these changes
Oct 15, 2024
apps/multisig/src/domains/offchain-data/address-book/hooks/useGetAddressesByOrgIdAndAddress.ts
Outdated
Show resolved
Hide resolved
…GetAddressesByOrgIdAndAddress.ts Co-authored-by: Chris Ling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored
useKnownAddresseshook to handle fetching contacts by their addresses, instead of relying onaddressBookByOrgIdStateatom which is populated byAddressBookWatcherthat polls 1000 contact addresses, categories and subcategories every 10 seconds.This is the first step towards moving away from the
AddressBookWatcherpattern. Next will be anAddresssInputrefactor to be an infinite, scrollable and searchable input that fetches X contacts at a time.Components refactored: