feat: support case-insensitive input handling in menu selection #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the input handling mechanism to accept both uppercase and lowercase letters for menu navigation commands. This change ensures the script can handle inputs more flexibly, accommodating both 'i' and 'I', 'c' and 'C', 'q' and 'Q', 'a' and 'A'. This enhancement was prompted by user feedback that the interface displays uppercase letters for action prompts, leading to a natural expectation that uppercase inputs would be accepted (Issue TNG#39). This update aligns the script's functionality with user expectations, enhancing usability and accessibility during interactive sessions. Tested on MacOS 14.5 with bash v5.2 shell. Resolves TNG#39 Signed-off-by: Cornelius Roemer <[email protected]>
|
Works as intended. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the input handling mechanism to accept both uppercase and lowercase letters for menu navigation commands.
This change ensures the script can handle inputs more flexibly, accommodating both 'i' and 'I', 'c' and 'C', 'q' and 'Q', 'a' and 'A'.
This enhancement was prompted by user feedback that the interface displays uppercase letters for action prompts, leading to a natural expectation that uppercase inputs would be accepted (Issue #39).
This update aligns the script's functionality with user expectations, enhancing usability and accessibility during interactive sessions. Tested on MacOS 14.5 with bash v5.2 shell.
Resolves #39