Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case sensitivity for the actions #39

Closed
matthewmrichter opened this issue Aug 22, 2023 · 1 comment · Fixed by #49
Closed

Case sensitivity for the actions #39

matthewmrichter opened this issue Aug 22, 2023 · 1 comment · Fixed by #49

Comments

@matthewmrichter
Copy link

matthewmrichter commented Aug 22, 2023 •
edited
Loading

Nice tool. But when you make a query with please-cli, you get these action prompts:

❗ What should I do? [use arrow keys or initials to navigate]
> [I] Invoke   [C] Copy to clipboard   [Q] Ask a question   [A] Abort

Note that the keys displayed are capital letters. It was my instinct to hit the capital I for example to invoke. But it seems that only the lower case letters (i etc.) actually work. This app should either display lower case letters for the actions or maybe more ideally be case-insensitive.

Please 0.3.0 Tested on MacOS Ventura 13.5.1, installed w/ homebrew, using zsh shell in mac terminal app
xenia-lang added a commit to xenia-lang/please-cli that referenced this issue Apr 26, 2024
@xenia-lang
Issue TNG#39: Make action selection caseinsensitive
b0dff89
xenia-lang added a commit to xenia-lang/please-cli that referenced this issue Apr 26, 2024
@xenia-lang
TNG#39: Make action selection caseinsensitive
25e6196
xenia-lang added a commit to xenia-lang/please-cli that referenced this issue Apr 26, 2024
@xenia-lang
TNG#39: Make action selection caseinsensitive
f6b650d 
Signed-off-by: Xenia Lang <[email protected]>
@corneliusroemer
Copy link
Contributor

Came here to open this issue. Faced exactly this problem.

corneliusroemer added a commit to corneliusroemer/please-cli that referenced this issue Jul 5, 2024
@corneliusroemer
feat: support case-insensitive input handling in menu selection
cbe6277 
Modified the input handling mechanism to accept both uppercase and lowercase letters for menu navigation commands.

This change ensures the script can handle inputs more flexibly, accommodating both 'i' and 'I', 'c' and 'C', 'q' and 'Q', 'a' and 'A'.

This enhancement was prompted by user feedback that the interface displays uppercase letters for action prompts, leading to a natural expectation that uppercase inputs would be accepted (Issue TNG#39).

This update aligns the script's functionality with user expectations, enhancing usability and accessibility during interactive sessions. Tested on MacOS 14.5 with bash v5.2 shell.

Resolves TNG#39
@corneliusroemer corneliusroemer mentioned this issue Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support case-insensitive input handling in menu selection corneliusroemer/please-cli
2 participants
@matthewmrichter @corneliusroemer