Separate Scenario filenames, ids, and report headers for v4 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to main, v3
Update to main, tests still expected to fail
* Separate Scenario report heading vs. filename vs scenario id Basically, instead of putting numbers in scenario headers and/or adjusting tests to allow those to pass, I'm trying to make a more extensive change to how we're managing that whole system. Adds base-scenario-file-name creation and adds tests for that too. Uses "-" as separator for major items as long as it doesn't break our .gitignore and artifact-getting name matching in the workflows. A change in that will have to wait for a breaking version. * Remove unused function * Don't change file name parts unnecessarily
plocket
changed the title
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate Scenario filenames, ids, and report headers
Same as #382. Closes #371. This has already been reviewed when #463 was merged.