Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers in safe filenames and report text #371

Closed
plocket opened this issue Aug 11, 2021 · 3 comments · Fixed by #382
Closed

Allow numbers in safe filenames and report text #371

plocket opened this issue Aug 11, 2021 · 3 comments · Fixed by #382
Assignees
@niharikasingh @plocket
Labels
quick

Comments

@plocket
Copy link
Collaborator

plocket commented Aug 11, 2021

Right now, scenario names get stripped of numbers when converting them to either of the above. Avoid stripping those out as they can be quite useful.
@plocket plocket added the quick label Sep 3, 2021
@niharikasingh
Copy link
Collaborator

The main place this conversion to safe filenames happens is in getSafeScenarioFilename, and there might be a few other scattered places.

@niharikasingh niharikasingh self-assigned this Sep 3, 2021
@niharikasingh niharikasingh mentioned this issue Sep 29, 2021
Merged
@plocket plocket self-assigned this Dec 29, 2021
@plocket
Copy link
Collaborator Author

plocket commented Dec 31, 2021

I think this exercise has highlighted that there are a few concerns that need to be separated - the scenario id, the scenario report heading, and the scenario filename. I've made PR #463 on the current PR branch for this issue.

This was referenced Jan 7, 2022
Merged
Merged
@plocket
Copy link
Collaborator Author

plocket commented Jan 7, 2022

Closed by #463 and #476

@plocket plocket closed this as completed Jan 7, 2022
plocket added a commit that referenced this issue Jan 7, 2022
@plocket
Bump version for separating Scenario names concerns, #371
4e7cd8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niharikasingh niharikasingh

@plocket plocket

Labels
quick
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate Scenario filenames, ids, and report headers for v3 SuffolkLITLab/ALKiln
2 participants
@niharikasingh @plocket