Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chokidar file watcher fails when projectRoot is "complex" #1601

Closed
misode opened this issue Sep 17, 2024 · 1 comment · Fixed by #1602
Closed

Chokidar file watcher fails when projectRoot is "complex" #1601

misode opened this issue Sep 17, 2024 · 1 comment · Fixed by #1602
Assignees
@misode
Labels
🐛 bug Something isn't working ❗high priority

Comments

@misode
Copy link
Member

misode commented Sep 17, 2024 •
edited
Loading

When the project root is something like file:///c%3A/Users/User/Documents/sandbox/Foo%20Bar%20%5Bv1.310%5D/, this is converted to c:\\Users\\User\\Documents\\sandbox\\Foo Bar [v1.310]\\ before being passed to Chokidar.
@misode misode added 🐛 bug Something isn't working ❗high priority labels Sep 17, 2024
@misode misode self-assigned this Sep 17, 2024
@misode
Copy link
Member Author

misode commented Sep 17, 2024

It seems like paulmillr/chokidar#699 has the solution. We should add disableGlobbing: true to the chokidar options.

misode added a commit to misode/SPYGlass that referenced this issue Sep 17, 2024
@misode
🐛 Fix SpyglassMC#1601 disable chokidar globbing
2f5203b
@misode misode mentioned this issue Sep 17, 2024
Merged
@misode misode mentioned this issue Nov 27, 2024
Closed
This was referenced Dec 10, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misode misode

Labels
🐛 bug Something isn't working ❗high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Disable chokidar globbing misode/SPYGlass
1 participant
@misode