Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find pack.mcmeta when projectRoot is "complex" #1572

Closed
SPGoding opened this issue Aug 17, 2024 · 3 comments · Fixed by #1599
Closed

Cannot find pack.mcmeta when projectRoot is "complex" #1572

SPGoding opened this issue Aug 17, 2024 · 3 comments · Fixed by #1599
Assignees
Labels
🐛 bug Something isn't working ❗high priority

Comments

@SPGoding
Copy link
Member

SPGoding commented Aug 17, 2024

Example project root that doesn't work: file:///c%3A/Users/foo/AppData/Roaming/.minecraft/saves/%C2%A7a%C2%A7lVersion%201.21%20%C2%A74%C2%A7l%5B4.5%5D%C2%A77/datapacks/bar/, which after percent decoding is file:///c:/Users/foo/AppData/Roaming/.minecraft/saves/§a§lVersion 1.21 §4§l[4.5]§7/datapacks/bar/

Maybe all those percent encoding messed something up?

@SPGoding SPGoding added the 🐛 bug Something isn't working label Aug 17, 2024
@SPGoding SPGoding added this to the Release 4.3.0 milestone Aug 17, 2024
@misode misode pinned this issue Aug 22, 2024
@misode
Copy link
Member

misode commented Aug 22, 2024

This may be the root cause that is causing those unexplained undeclared symbol issues in the few reported cases

@misode
Copy link
Member

misode commented Aug 28, 2024

The issue seems to be caused by sindresorhus/globby#81

I didn't immediately find a workaround. We should probably not use glob matching to walk the file tree.

@SPGoding
Copy link
Member Author

I assume it should not be too difficult to implement a file tree walk ourselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ❗high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants