Remove 18 #248
Closed
Remove 18 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2024
rowleya
reviewed
Mar 19, 2024
Comment on lines
+36
to
+39
| .. note:: | ||
| The processor_ids and link_ids parameters are only optional if a | ||
| spinnaker_route is provided. If a spinnaker_route is provided | ||
| the processor_ids and link_ids parameters are ignored. |
There was a problem hiding this comment.
A potential way to avoid this "multi-constructor" is instead to have a static method which is something like "def from_procs_and_links(processor_ids, link_ids)" which does the conversion and just calls the spinnaker_route constructor. That then makes it harder to do something inconsistent...
rowleya
reviewed
Mar 19, 2024
Comment on lines
+32
to
+33
| def __init__(self, processor_ids: Union[int, Iterable[int], None], | ||
| link_ids: Union[int, Iterable[int], None], |
There was a problem hiding this comment.
Can't quite remember if we prefer Optional rather than Union[..., None], though if the comment below is taken into account, this would of course go away...
|
replaced by #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PRs remove some of the hard coded 18 Cores
MulticastRoutingEntry, FixedRouteEntry and MulticastRoutingTableByPartitionEntry now have a shared BaseMulticastRoutingEntry.
MAX_LINKS_PER_ROUTER = 6 moved to constants
Must be done at the same time as:
SpiNNakerManchester/SpiNNMan#395
SpiNNakerManchester/PACMAN#550
SpiNNakerManchester/SpiNNFrontEndCommon#1169
tested by:
SpiNNakerManchester/IntegrationTests#260