Remove 18 #550
Closed
Remove 18 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2024
rowleya
reviewed
Mar 19, 2024
|
|
||
| def __init__(self, out_going_links: Union[int, Iterable[int], None], | ||
| outgoing_processors: Union[int, Iterable[int], None], | ||
| incoming_processor: Optional[int] = None, | ||
| incoming_link: Optional[int] = None): | ||
| incoming_link: Optional[int] = None, | ||
| spinnaker_route: Optional[int] = None): |
There was a problem hiding this comment.
Do we actually make use of this here? I would have thought it would never be called in this way...
There was a problem hiding this comment.
OK, I see this is used internally...
There was a problem hiding this comment.
This might be another case where we could have a "from_processor_and_links" function or something like that. It might alternatively then hold a SpiNNMachine routing entry rather than extend it, but not sure if that would help things here...
There was a problem hiding this comment.
The main need for these is in the Mundy routers.
Allow these to be lost and I think the secondary usage of seeing is a route is defaulable can be handled at init time.
rowleya
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of SpiNNakerManchester/SpiNNMachine#248
MulticastRoutingTableByPartitionEntry
-incoming processor and link id now stored separately