Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ffe-account-selector-react)!: remove AccountSelectorHighCapacity #1670

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ AccountSelector.propTypes = {
ariaInvalid: oneOfType([string, bool]).isRequired,
/** Defines if you should save space for account details that is shown when an account is selected */
withSpaceForDetails: bool,
/**
* For situations where AccountSelector might be populated with hundreds of accounts,
* uses react-window for performance optimization, default false.
* This prop will be passed on to SearchableDropdown.
* The account selector with highCapacity is currently not working with VoiceOver on ios.
*/
onClose: func,
/** Prop passed to the dropdown list */
onOpen: func,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export { AccountSelector } from './AccountSelector';
export { AccountSelectorHighCapacity } from './AccountSelectorHighCapacity';
16 changes: 1 addition & 15 deletions packages/ffe-account-selector-react/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,10 @@ export interface AccountSelectorProps<T extends Account = Account> {
onClose?: () => void;
}

export interface AccountSelectorHighCapacityProps<T extends Account = Account>
extends AccountSelectorProps<T> {}

declare class AccountSelector<
T extends Account = Account
> extends React.Component<AccountSelectorProps<T>> {}

declare class AccountSelectorHighCapacity<
T extends Account = Account
> extends React.Component<AccountSelectorHighCapacityProps<T>> {}

export interface AccountSelectorMultiProps<T extends Account = Account> {
accounts?: Array<T>;
id: string;
Expand All @@ -67,7 +60,6 @@ export interface AccountSelectorMultiProps<T extends Account = Account> {
selectedAccounts?: Array<T>;
showSelectAllOption?: boolean;
value?: string;
highCapacity?: boolean;
}

declare class AccountSelectorMulti<
Expand Down Expand Up @@ -98,14 +90,8 @@ export interface BaseSelectorProps {
id?: string;
name?: string;
readOnly?: boolean;
highCapacity?: boolean;
}

declare class BaseSelector extends React.Component<BaseSelectorProps, any> {}

export {
AccountSelector,
AccountSelectorMulti,
BaseSelector,
AccountSelectorHighCapacity,
};
export { AccountSelector, AccountSelectorMulti, BaseSelector };
5 changes: 1 addition & 4 deletions packages/ffe-account-selector-react/src/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
export {
AccountSelector,
AccountSelectorHighCapacity,
} from './components/account-selector';
export { AccountSelector } from './components/account-selector';
export { default as AccountSelectorMulti } from './components/account-selector-multi';
export { default as BaseSelector } from './components/base-selector';