Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ffe-account-selector-react)!: remove AccountSelectorHighCapacity #1670

Merged

Conversation

simen-sb1
Copy link
Contributor

AccountSelectorHighCapacity depends on SearchableDropdownHighCapacity from ffe-searchable-dropdown-react, which depends on react-virtualization; a package which is no longer maintained and does not work seamlessly with modern build tools such as vite.

If high capacity is still needed, use AccountSelectorMulti or BaseSelector with prop highCapacity=true.

BREAKING CHANGE: AccountSelectorHighCapacity is no longer exported. Use AccountSelectorMulti or BaseSelector with prop highCapacity=true

Beskrivelse

Fjerner komponenten AccountSelectorHighCapacity

Motivasjon og kontekst

I forbindelse med overgang fra bundling med webpack til vite i mange SB1 apper, er det lagt inn "hacks" i alle apper som benytter ffe-account-selector-react eller ffe-searchable-dropdown-react for å få vite.js til å fungere i samspill med react-virtualization; et lib som ikke lenger vedlikeholdes. Nå som behovet for highCapacity virker å stort sett ha forsvunnet, samtidig som det har dukket opp nyere bibliotek for virtualisering, er det et bedre alternativ å fjerne komponentene som avhenger av react-virtualization nå, så kan de som evt. måtte trenge virtualisering senere ta jobben med å implementere dette med nye avhengigheter.

Testing

AccountSelectorHighCapacity depends on SearchableDropdownHighCapacity
from ffe-searchable-dropdown-react, which depends on
react-virtualization; a package which is no longer maintained and
does not work seamlessly with modern build tools such as vite.

If high capacity is still needed, use AccountSelectorMulti or
BaseSelector with prop highCapacity=true.

BREAKING CHANGE: AccountSelectorHighCapacity is no longer exported.
Use AccountSelectorMulti or BaseSelector with prop highCapacity=true
@simen-sb1 simen-sb1 requested a review from a team as a code owner August 29, 2023 14:03
@HeleneKassandra
Copy link
Contributor

HeleneKassandra commented Aug 31, 2023

Før du merger, kan du fjerne ! fra commitmeldingen? :)

Ville gjort det selv, men er alltid vanskeligere å gjøre det fra remote branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants