chore(ffe-account-selector-react)!: remove AccountSelectorHighCapacity #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccountSelectorHighCapacity depends on SearchableDropdownHighCapacity from ffe-searchable-dropdown-react, which depends on react-virtualization; a package which is no longer maintained and does not work seamlessly with modern build tools such as vite.
If high capacity is still needed, use AccountSelectorMulti or BaseSelector with prop highCapacity=true.
BREAKING CHANGE: AccountSelectorHighCapacity is no longer exported. Use AccountSelectorMulti or BaseSelector with prop highCapacity=true
Beskrivelse
Fjerner komponenten AccountSelectorHighCapacity
Motivasjon og kontekst
I forbindelse med overgang fra bundling med webpack til vite i mange SB1 apper, er det lagt inn "hacks" i alle apper som benytter ffe-account-selector-react eller ffe-searchable-dropdown-react for å få vite.js til å fungere i samspill med react-virtualization; et lib som ikke lenger vedlikeholdes. Nå som behovet for highCapacity virker å stort sett ha forsvunnet, samtidig som det har dukket opp nyere bibliotek for virtualisering, er det et bedre alternativ å fjerne komponentene som avhenger av react-virtualization nå, så kan de som evt. måtte trenge virtualisering senere ta jobben med å implementere dette med nye avhengigheter.
Testing