Drop support for single-valued "sonar.cs.roslyn.reportFilePath" and "… #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-caro-sonarsource
force-pushed
the
mc/888
branch
2 times, most recently
from
59fb3b4 to
fef0131
Compare
pavel-mikula-sonarsource
requested changes
Oct 26, 2020
pavel-mikula-sonarsource
requested changes
Oct 26, 2020
pavel-mikula-sonarsource
requested changes
Oct 26, 2020
…sonar.cs.analyzer.projectOutPath" (and VB.Net siblings)
mickael-caro-sonarsource
force-pushed
the
mc/888
branch
from
f3c9b93 to
240e0a0
Compare
|
Thanks @pavel-mikula-sonarsource i did some fixes after you review, can you please check ? Thanks ! |
|
@mickael-caro-sonarsource force-pushing changes in the middle of a PR makes it much harder for a reviewer to understand the changes made in the course of the PR. If you don't force-push then the reviewer has the option to focus on a subset of the commits as a review progresses to see what's changed during the review. Force-pushing means they lose all that context and are effectively looking at a new PR. |
|
@duncanp-sonar sorry about that, i kept this habit from SC core. |
|
@mickael-caro-sonarsource wow, they must enjoy making life difficult for themselves! ;-) |
pavel-mikula-sonarsource
requested changes
Oct 27, 2020
Tests/SonarScanner.MSBuild.Shim.Tests/PropertiesFileGeneratorTests.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
mickael-caro-sonarsource
added a commit
that referenced
this pull request
Oct 30, 2020
#902) * Drop support for single-valued "sonar.cs.roslyn.reportFilePath" and "sonar.cs.analyzer.projectOutPath" (and VB.Net siblings)
mickael-caro-sonarsource
added a commit
that referenced
this pull request
Nov 2, 2020
* Moved from WebClient to HttpClient. (#841) * Split TFS-specific code in a separate exe (#896) * Update license headers (#895) * Detect and take VsTestToolsInstallerInstalledToolLocation environment variable to set CodeCoverage.exe path. (#903) * Remove/Changed SonarQube-only log messages to be more generic with So… (#898) * Remove/Changed SonarQube-only log messages to be more generic with SonarCloud. * Fail fast if sonar.organization is provided in SonarQube.Analysis.xml (#901) * Changed deprecated projectKey parameters while fetching Quality Profile (#899) * Added .NET 5 flavor for the Scanner (#884) * Drop support for single-valued "sonar.cs.roslyn.reportFilePath" and "… (#902) * Drop support for single-valued "sonar.cs.roslyn.reportFilePath" and "sonar.cs.analyzer.projectOutPath" (and VB.Net siblings) * Add support for pure .NET Core Projects (#887) * If a ProjectGuid has not been found in either the csproj or the solution, generate a random one. * Fail fast in case the server license is invalid. (#907) * fixed bug - skipped shared across projects files (#876) * Update documentation (Proxy, .NET Core NET Version, added back conditional blocks for SQ/SC (#905) * Add a warning and clearer message in case of falling back to SonarOutputDir projectbBaseDir. (#908) * Add build configuration to TFS build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sonar.cs.analyzer.projectOutPath" (and VB.Net siblings)
fixes #888