Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental PR Analysis: Validate cache keys #1431

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Incremental PR Analysis: Validate cache keys #1431

merged 2 commits into from
Dec 6, 2022

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Fixes #1430

@pavel-mikula-sonarsource
Copy link
Contributor Author

We cannot add null as a value, it violates the Protobuf contract and throws argument exception when we try to set it

costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit cb2c2c4 into master Dec 6, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/FixKeys branch December 6, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incremental PR Analysis: Validate cache keys
2 participants
@pavel-mikula-sonarsource @costin-zaharia-sonarsource