Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental PR Analysis: Validate cache keys #1430

Closed
pavel-mikula-sonarsource opened this issue Dec 6, 2022 · 0 comments · Fixed by #1431
Closed

Incremental PR Analysis: Validate cache keys #1430

pavel-mikula-sonarsource opened this issue Dec 6, 2022 · 0 comments · Fixed by #1431
Assignees
@pavel-mikula-sonarsource
Milestone
5.9.1

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

We do not always control keys of the cache, as other analyzers can create their own cache with unexpected keys.

We need to make sure that the cache key is a valid path before passing it to file processing to avoid

ArgumentException: Illegal characters in path.
@pavel-mikula-sonarsource pavel-mikula-sonarsource added this to the 5.9.1 milestone Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-mikula-sonarsource pavel-mikula-sonarsource

Labels
None yet
Projects
None yet
Milestone
5.9.1
Development

Successfully merging a pull request may close this issue.

Incremental PR Analysis: Validate cache keys SonarSource/sonar-scanner-msbuild
2 participants
@costin-zaharia-sonarsource @pavel-mikula-sonarsource