Add reproducers for S2583/S2589 issues #7793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
force-pushed
the
mary/fix-uts
branch
from
54f41f5 to
9826ebd
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fix-uts
branch
from
aca8f6e to
6ac7758
Compare
Tim-Pohlmann
approved these changes
Aug 15, 2023
| return false; | ||
| } | ||
|
|
||
| if (foundA) // Noncompliant FP, we run the loop only three times and SE never learns that foundA can be True. |
There was a problem hiding this comment.
Suggested change
| if (foundA) // Noncompliant FP, we run the loop only three times and SE never learns that foundA can be True. | |
| if (foundA) // Noncompliant FP, we run the loop twice but the second branch never leaves the loop |
|
|
||
| if (foundA) // Noncompliant FP, we run the loop only three times and SE never learns that foundA can be True. | ||
| { | ||
| return true; // Secondary |
There was a problem hiding this comment.
Suggested change
| return true; // Secondary | |
| return true; // Secondary FP |
| { | ||
| public void Method(Guid guid) | ||
| { | ||
| if (guid == null || guid == Guid.Empty) // Noncompliant S2589, no secondary issue is raised. |
There was a problem hiding this comment.
Validate the message to prove that the correct issue is being raised.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add repros for #5002, #5601, #739, #2411
Update UTs and UT annotations.